-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename babel-plugin-minify-computed-member-expressions to the existin… #33
Conversation
072490a
to
123f37e
Compare
|
111085e
to
b2ec0f8
Compare
…g babel-plugin-transform-member-expression-literals
…move out of simplify plugin
…orm-minify-booleans
…-transform-property-literals
b2ec0f8
to
f77b281
Compare
f77b281
to
beced12
Compare
LGTM -- merge whenever you're ready (make sure tests pass and no regression in benchmarks) |
I might as well move over
|
Not sure why I'm getting different results from cloning/npm i/bootstrap
new
Ignore: |
Ok just found out the benchmark doesn't run all the plugins |
|
@@ -73,6 +73,14 @@ function test(name, callback) { | |||
}); | |||
} | |||
|
|||
test('minify-preset', function (code, callback) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can just replace below one with this (wasn't sure if that was specifically needed) @amasad
Oops.. mean't to do a regular merge commit (oh well) Will do
in another pr |
…g babel-plugin-transform-member-expression-literals
Ref #19 (comment)
Should all of the plugins be namespaced under
minify-
? or should we reuse the old ones and move them over?babel-plugin-minify-computed-properties
After this PR/Release