Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Tests #36

Closed
hzoo opened this issue Jun 28, 2016 · 7 comments
Closed

Integration Tests #36

hzoo opened this issue Jun 28, 2016 · 7 comments

Comments

@hzoo
Copy link
Member

hzoo commented Jun 28, 2016

Ref #33 (comment)

The benchmarks are cool, but we could reduce the size and find out we are breaking the functionality (especially for the dead code elimination plugin).

So we could be running the unit tests of the project on the minified code?

@sebmck
Copy link
Contributor

sebmck commented Jun 28, 2016

I need something like this for another project I'm working on. Could likely make some generic framework for it.

@amasad
Copy link
Member

amasad commented Jun 29, 2016

That's could idea. Doubles as integration test

On Tue, Jun 28, 2016, 4:57 PM Sebastian McKenzie notifications@github.com
wrote:

I need something like this for another project I'm working on. Could
likely make some generic framework for it.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#36 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAj2_lJfHvhpPzNI8xMDflvkYrBadARfks5qQbUBgaJpZM4JApf4
.

@hzoo
Copy link
Member Author

hzoo commented Jun 29, 2016

I know esprima had something (since I got pinged about jscs failing the builds sometimes) https://github.com/jquery/esprima/blob/master/test/downstream.js

Either fixtures like we are doing or using npm/node_modules or git submodules, or even some kind of ci service?

@boopathi
Copy link
Member

boopathi commented May 9, 2017

We have Smoke tests(#492) now that runs against 3 libraries (lodash, html-minifier, jquery) running all it's tests on the babilified code. Will re-open this if there are more ideas and requirements.

@boopathi boopathi closed this as completed May 9, 2017
@amasad
Copy link
Member

amasad commented May 9, 2017

@boopathi did you consider running test262?

@boopathi
Copy link
Member

boopathi commented May 9, 2017

Yes. Have to try it out. Do you think we should we re-open this for test262?

@amasad
Copy link
Member

amasad commented May 10, 2017

or some other issue, eitherways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants