Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jest test updates #75

Merged
merged 4 commits into from
Aug 2, 2016
Merged

Jest test updates #75

merged 4 commits into from
Aug 2, 2016

Conversation

hzoo
Copy link
Member

@hzoo hzoo commented Aug 2, 2016

Ref babel/babel#3621

We can also also use https://github.com/lodash/babel-plugin-lodash since we are importing lodash for some in the dead code elim package @amasad

"devDependencies": {
"babel-core": "^6.4.5",
"babel-cli": "^6.4.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this used. I guess babel-cli can be removed !

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I guess not since we are using gulp babel

@hzoo
Copy link
Member Author

hzoo commented Aug 2, 2016

@kangax should be simple

@@ -68,4 +68,25 @@ describe("remove-console-plugin", () => {
`);
expect(transform(source).trim()).toBe(expected);
});

it("statement no block", () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a new test?

Copy link
Member Author

@hzoo hzoo Aug 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it's from a pr to babel (since I moved the plugin to this repo) babel/babel#3583

@kangax kangax merged commit d4ff6f8 into master Aug 2, 2016
@kangax kangax deleted the jest-test-updates branch August 2, 2016 23:49
@hzoo hzoo mentioned this pull request Aug 2, 2016
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants