Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify channel input in PsPM functions #679

Closed
dominikbach opened this issue Apr 5, 2024 · 0 comments · Fixed by #682
Closed

Unify channel input in PsPM functions #679

dominikbach opened this issue Apr 5, 2024 · 0 comments · Fixed by #682

Comments

@dominikbach
Copy link
Contributor

dominikbach commented Apr 5, 2024

Summary

  1. Most functions take an argument options.channel but some require a separate channel argument. This should be streamlined in the following way:
  • any function that has a default channel (e.g. modality-specific last channel) should take the channel input through options
  • any function that has no default (i.e. modality-unspecific functions such as pspm_extract_segments or pspm_pp) should take an explicit channel argument.
  1. Specifically, the following functions are reported to have mismatching channel input:
  • pspm_scr_pp: according to help, channel argument is entered via options, but the code actually expects a third argument. The GUI does not provide a third argument.
  • pspm_convert_ecg2hb and pspm_convert_ecg2hb_amri do not take the same channel input
@dominikbach dominikbach changed the title Bug in pspm_scr_pp Unify channel input in PsPM functions Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant