-
Notifications
You must be signed in to change notification settings - Fork 254
invalid semver tags prevent use of backbone.paginator with Bower #188
Comments
My suggestion would be to release a @addyosmani @wyuenho Any objections? |
The old tags also start with a |
The v is actually not part of the tag so the actual tags out there are 0.8, 0.7 etc. Releasing a 0.8.1 tag would do the trick for most people though It would be nice to give those people with more sensitive QA needs / higher impact systems the option to use bower without forcing an upgrade by releasing a x.x.1 for all tags but 0.8.1 would be a great start. |
What @baer said :) Just make a new tag. |
Sorry to be pedantic but I want to get this right: If you look here you'll see that the git tag does include a |
@Lenniboy is right, for some reason I thought it was github that was appending the "v" to the tag but after checking out the repo and running 0.8.1 |
The thing is, you can put any semvar inside bower.json and you can submit it. You can even search for it from bower. It just can't check out the repo if it doesn't have such a tag. Regardless, like @baer said, you can just retag all the existing tags and submit a bower.json with an actual semvar version number and everything should just work as intended. |
Ok, I will release a version If people haven't been able to use the previous versions with Bower anyway is there really a need to add the semver-compliant tags anyway? |
|
You have my permission to retag all previous releases. There may be a chance it's going to cause dependency resolution issues for users but I would like us to be able to resolve our longer-term Bower/versioning problems. Thanks for releasing 0.8.1, @Lenniboy! |
Question: where does the bower.json live now? I don't see it in the repo. |
Bower doesn't need it's dependency file to be called bower.json. All the info is in package.json |
Thanks for the release! Just pulled the project in successfully with Bower this morning. |
Bower only allows you to specify a tag if the tag is a valid semver e.g. 0.8.0. If you cannot provide it with a valid version it will ONLY allow you to checkout latest which for a production site is not acceptable.
The versioning in the package.json files are correct but because the tags themselves are of the form 0.8 and not 0.8.0 bower is disallowing tags from this repo. There are open issues in the Bower project that talk about this but until they are fixed I'd like to ask if it would be acceptable to publish new tags or do a minor rev of the last few releases to make them compatible as this drastically limits community adoption.
Thanks for all your great work!
41
141
433
275
The text was updated successfully, but these errors were encountered: