This repository has been archived by the owner on Jul 4, 2021. It is now read-only.
Passing root into the paginator #268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm passing root into the paginator module, because I discovered some compatibility issues with backbone.paginator and npm unwrap. If root is passed in, the paginator can be unwrapped correctly.
A slight modification to passing root into the paginator. Now the tests should pass.
|
Please deal with your whitespace issues. |
|
@keithb418 Can you fix this PR up? I can't read the diff |
|
closing for there's no response |
|
Also please file a bug to npm unwrap. Libraries are not the place to deal with build tool parser issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm passing root into the paginator module, because I discovered some compatibility issues with backbone.paginator and npm unwrap. If root is passed in, the paginator can be unwrapped correctly.