Skip to content
This repository has been archived by the owner on Jul 4, 2021. It is now read-only.

Fix : RequestPager Example Sorting Issue #35

Merged
merged 1 commit into from
Jun 1, 2012

Conversation

hardfire
Copy link
Contributor

@hardfire hardfire commented Jun 1, 2012

The demo at Backbone.Paginator.requestPager() does nothing on 'Sort By' .

issue page

@alexandernst
Copy link
Member

Oh, btw, can we get a patch for the infinite-paging example too? It's exactly the same code.

@hardfire
Copy link
Contributor Author

hardfire commented Jun 1, 2012

Actually, the infinite-paging example doesn't have a sort option.
if we add one then we might have to use this fix and also start the page number from 0 when changed. i suppose.
Right now the sort is kind of hard-coded as 'ReleaseYear'

@alexandernst
Copy link
Member

Oh, yes, you're right, sorry :)
Then don't add it.

addyosmani added a commit that referenced this pull request Jun 1, 2012
Fix : RequestPager Example Sorting Issue
@addyosmani addyosmani merged commit 45a159b into backbone-paginator:master Jun 1, 2012
@addyosmani
Copy link
Member

Thank you for this!

@hardfire
Copy link
Contributor Author

hardfire commented Jun 1, 2012

you're welcome.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants