-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[D8] Provide image style tokens (imagecache_token module in core) #3594
Comments
That, plus the fact that this is in D8 core since its early versions, and we are aiming for as much feature parity as possible. Which makes this issue here part of #378 😉 |
Works for me -- awesome! |
I just pushed passing tests to the PR. |
In the weekly meeting today there was some resistance to adding these tokens into core. The concern is that perhaps the only place these tokens are used is in metatags, and metatag module is a contrib module. Perhaps this should remain a contrib module too? Adding the needs feedback label to see if others have different use-cases. |
Since it was mentioned above that this is already in D8 core, do we know what their use case is? I'd be happy to see this added for the reasons given already (adding to existing core functionality, feature parity with D8). |
I guess image style tokens could be used anywhere regular image tokens are used, and regular image tokens are in core... so I'm not sure I see the problem. It makes sense to me to have it in core, anyway. |
Me either. I thought this would be a no-brainer. as I thought these tokens
had simply been forgotten. ¯\_(ツ)_/¯
…On Fri, Sep 20, 2019, 7:39 AM Laryn - CEDC.org ***@***.***> wrote:
I guess image style tokens could be used anywhere regular image tokens are
used, and regular image tokens are in core... so I'm not sure I see the
problem. It makes sense to me to have it in core, anyway.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3594?email_source=notifications&email_token=AADBER73NRPYJG35GGGZ7MDQKTOC7A5CNFSM4G7JN3I2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7G4YIQ#issuecomment-533580834>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADBER4DKBBJYQEDWYTSAK3QKTOC7ANCNFSM4G7JN3IQ>
.
|
Sorry I missed today's dev meeting, when this issue was brought up. I watched the recording afterwards, and it seemed to me that we are looking for the reasoning behind why this was added to core in D8, and why not have it live in contrib instead. So I have taken the time to go through the d.org issue that introduced this change, and here's a few of the comments that may make it a case for core:
|
...there's another issue in d.org against the D8 core Token module, which is related: Add support for field properties , which links to https://www.drupal.org/project/token/issues/2430827 ...and that one in turn seems to have about half a dozen of children issues. |
So those sound like arguments for leaving this in contrib? Maybe even as part of the metatag module?
|
That was my thought too, after reading @klonos' quotes from D.org... If there's no use-case for this other than social media's |
...the/another use case for core is mobile devices, where you need "automagic" derivatives of images you upload, so that people don't download a 2MB image in their phone, over mobile data networks (where speed/cost is an issue). To that effect, we could have also left #869 to contrib, but we implemented it in core 😉 |
...long-term, this might fit into #1440 too 😉 |
@klonos I don't see how the mobile device thing is a relevant use case for image style tokens. Are you thinking that we could do something like the |
I'm stuck on the failing test. backdrop/backdrop#2849 (comment) |
I pushed a commit to the PR that should fix the two failing tests. Because the image styles are cached in memory, if you modify the image styles in various POST requests, the static in-memory cache must be cleared in the testing thread to get a fresh list of styles from the database. So I just added two |
There are a few changes that I think we should make here, I posted a review to the PR: backdrop/backdrop#2849 (review) There are some features here that I think are too granular for core, like Lastly, if this is replacing a contrib module in its entirety, we should add it to |
It doesn't have an update hook yet to disable the contrib version, nor backdrop_merged_modules. |
There is no Backdrop version of |
Looks like the |
By @jenlampton, @laryn, @herbdool, @BWPanda, and @klonos.
Merged backdrop/backdrop#2849 into 1.x for 1.17.0. Thanks everyone! |
Description of the need
The functionality of Imagecache Token could be merged into the existing token functionality. (It looks like this functionality is merged into token in D8.)
Proposed solution
Since token is in core, I think merging this image style token functionality into core would be ideal.
I would like to be the advocate for getting this feature into 1.15. I've added the milestone candidate label.
Core minor release advocate: @jenlampton
PR by @jenlampton: backdrop/backdrop#2849
The text was updated successfully, but these errors were encountered: