Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line highlighting in codeblocks has changed #183

Closed
bforbis opened this issue Apr 4, 2024 · 2 comments
Closed

Line highlighting in codeblocks has changed #183

bforbis opened this issue Apr 4, 2024 · 2 comments

Comments

@bforbis
Copy link

bforbis commented Apr 4, 2024

I have recently just upgraded mkdocs-techdocs-core from v1.2.3 -> v1.3.5 and have been testing on my documentation smoke test page and noticed a significant change in how codeblock highlighting is visualized using the hl_lines directive.

Version 1.2.3
image

Version ^1.3.3
image

I'm not sure if this was an intentional style change or is a bug, but the new way that line highlighting works is too subtle and easy to miss.

I've done some testing of versions in between and this seems to have been introduced in mkdocs-techdocs-core@v1.3.3, which bumped mkdocs-material to 9.4.14

Looking at the css of the .hll and .highlight CSS class, it looks like the background-color was updated:

Old: background-color: var(--md-code-hl-color)
New: background-color: var(--md-code-hl-color--light)

This seems to have been changed in mkdocs-material as reported in squidfunk/mkdocs-material#6017

@pwalleni
Copy link

Here too. Please fix. Thanks.

@awanlin
Copy link
Collaborator

awanlin commented Jun 27, 2024

Closing as this looks to be fixed in the upstream Backstage repo by backstage/backstage#24809

@awanlin awanlin closed this as completed Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants