Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Job Filters To GET Requests. Links in Dashboard #13

Closed
wants to merge 2 commits into from

Conversation

atze234
Copy link

@atze234 atze234 commented Mar 29, 2018

@atze234
Copy link
Author

atze234 commented Mar 29, 2018

@dfranco
Copy link
Member

dfranco commented Mar 29, 2018

Hi @atze234,

Thanks for this merge request.
I see a lot of changes, can you explain a bit more the purpose of these changes ?

By the way, you've cloned the wrong branch (master instead of develop).
http://docs.bacula-web.org/en/latest/04_contribute/development.html#guidance-for-developpers

I'll get back to you once I've reviewed your changes.

Cheers

@atze234
Copy link
Author

atze234 commented Mar 29, 2018

Hi @dfranco ,
sorry for the wrong branch.
I wanted to separate those 2 Commits, but did that wrong i think, did not branch i think -.- Not using github often :(

The purpose of the Changes of my first commit:
Change POST to GET Requests in the Search Forms (Jobs firstofall, so that i can hit the "Back" Button in Browser. Second, with GET Requests for the Search Filter we can Link things easily. So i created some Links (Failed Jobs/Succeeded Jobs on the Dashboard)

In my second Commit i've added an extra Sort Order on the Volumes Page, so that i can Sort by Inchanger and Name for example. The Volumes View is quite hard to read with >1000 Volumes. And i added the inchanger sort keyword at all here. Maybe little too much copy&paste in the Volumes View Class, but ... i think its ok.

Best Regards

@dfranco
Copy link
Member

dfranco commented Apr 12, 2018

Hi @atze234 ,

For the first purpose, there's already a bug report open
http://bugs.bacula-web.org/view.php?id=195

For the second one, I've added a note the bug report.
Let me know what you think.

Anyway, I'll merge your code (at least some part) into the right branch.
It might not be in 8.0.0 stable release but the next one I guess.

Kind regards

@dfranco dfranco self-assigned this Oct 16, 2019
@dfranco
Copy link
Member

dfranco commented Dec 23, 2019

Hi @atze234 ,
I'll try to integrate some of your code in next 8.4.0 release.
Thanks for your contribution

@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dfranco
Copy link
Member

dfranco commented Oct 18, 2022

The first issue is fixed, and you can filter volumes with "in changer" checkbox.
I'm closing this PR.

Thanks a lot for your contribution

@dfranco dfranco closed this Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants