Only emit 'update' events after the entire state cache has been updated. #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently Ketting has a race condition for updates with embedded items. If items are embedded, we were sending out 'update' events even if the entire request wasn't processed yet. This can make it unpredictable to know whether a resource's parent or child is updated. This change processes an entire _embedded tree with sub-dependencies, and only after the entire tree is cached it will start sending out 'update' events. Now, when you receive an 'update' event the entire cache state is consistent.
mhum
approved these changes
Mar 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Ketting has a race condition for updates with embedded items.
If items are embedded, we were sending out 'update' events even if the
entire request wasn't processed yet.
This can make it unpredictable to know whether a resource's parent or
child is updated.
This change processes an entire _embedded tree with sub-dependencies,
and only after the entire tree is cached it will start sending out
'update' events.
Now, when you receive an 'update' event the entire cache state is
consistent.