Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only emit 'update' events after the entire state cache has been updated. #433

Merged
merged 1 commit into from
Mar 20, 2022
Merged

Only emit 'update' events after the entire state cache has been updated. #433

merged 1 commit into from
Mar 20, 2022

Commits on Mar 20, 2022

  1. Only emit 'update' events after the entire state cache has been updated. 

    Currently Ketting has a race condition for updates with embedded items.
If items are embedded, we were sending out 'update' events even if the
entire request wasn't processed yet.

This can make it unpredictable to know whether a resource's parent or
child is updated.

This change processes an entire _embedded tree with sub-dependencies,
and only after the entire tree is cached it will start sending out
'update' events.

Now, when you receive an 'update' event the entire cache state is
consistent.
    @evert
    evert committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    6e61015 View commit details
    Browse the repository at this point in the history