Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move osslifecycle and nycrc into /github #5343

Open
chris48s opened this issue Jul 18, 2020 · 5 comments
Open

move osslifecycle and nycrc into /github #5343

chris48s opened this issue Jul 18, 2020 · 5 comments
Labels
service-badge Accepted and actionable changes, features, and bugs

Comments

@chris48s
Copy link
Member

chris48s commented Jul 18, 2020

As noted in #5234 these two anomolies should be moved into the /github dir and URL namespace, like all the other "get a file from a github repo and extract a value" badges. We should set up redirects for compatibility.

@chris48s chris48s added the service-badge Accepted and actionable changes, features, and bugs label Jul 18, 2020
@chris48s chris48s changed the title move osslifecycle and nycrc into /gtihub move osslifecycle and nycrc into /github Jul 18, 2020
@calebcartwright
Copy link
Member

I know those two badges only support looking for their respective files in github today, but is there any reason that has to be the case? For example I could just easily use Bitbucket and nyc and want the badge. I know we haven't had any asks for those just yet, but perhaps worth considering.

@chris48s
Copy link
Member Author

Hmm.. that's broadly also true of all the other "get a file from a github repo and extract a value" badges. i.e:

  • github-go-mod
  • github-all-contributors
  • github-lerna-json
  • github-pipenv
  • github-manifest
  • github-package-json

Whichever way we look at it, we should treat osslifecycle and nycrc the same as all of those, but maybe there is a case that none of those should be github-specific

@calebcartwright
Copy link
Member

Excellent point!

Maybe in a perfect world we'd have a "get a file from (VCS provider) and extract a value" framework/reusable functions or base classes.

@calebcartwright
Copy link
Member

And just to clarify, I don't have any objections to moving these services under the github directory, regardless of what we may or may not do down the line. At this point it's really more about easily knowing where all the service classes are that use the GitHub APIs to do their thing.

@chris48s
Copy link
Member Author

Another relevant consideration here
#9516
adds a badge that just takes an arbitrary file (not hard-coded to GitHub). One of the issues here is: How these fit into the URL schema?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

No branches or pull requests

2 participants