Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pypi] Add Framework Version Badges support #8261

Merged
merged 7 commits into from Aug 1, 2022

Conversation

ericof
Copy link
Contributor

@ericof ericof commented Jul 29, 2022

Implements #8246

  • Creates /pypi/frameworkversions/:frameworkName/:packageName
  • Creates a redirect from /pypi/djversion/:packageName to /pypi/frameworkversions/Django/:packageName
  • Supports AWS CDK, Django, Django CMS, JupyterLab, Odoo, Plone, Wagtail, Zope . Those Frameworks are the only ones with explicit versions according to Trove Classifiers

@shields-ci
Copy link

shields-ci commented Jul 29, 2022

Messages
📖 ✨ Thanks for your contribution to Shields, @ericof!

Generated by 🚫 dangerJS against 0ef8c12

@lgtm-com
Copy link

lgtm-com bot commented Jul 29, 2022

This pull request introduces 2 alerts when merging 8133c76 into 202d72d - view on LGTM.com

new alerts:

  • 2 for Inefficient regular expression

@calebcartwright calebcartwright added the service-badge Accepted and actionable changes, features, and bugs label Jul 29, 2022
Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up. The implementation is looking pretty good already but I've left a few comments inline. I was hoping we might be able to get away without explicitly listing the frameworks, but the Jupyter :: JupyterLab case does make things a bit messy. Fortunately it is quite rare for new classifiers to be added and the way you've written this should make it quite easy to add new ones

services/pypi/pypi-django-versions.service.js Outdated Show resolved Hide resolved
services/pypi/pypi-framework-versions.service.js Outdated Show resolved Hide resolved
services/pypi/pypi-framework-versions.service.js Outdated Show resolved Hide resolved
services/pypi/pypi-framework-versions.service.js Outdated Show resolved Hide resolved
services/pypi/pypi-framework-versions.service.js Outdated Show resolved Hide resolved
services/pypi/pypi-framework-versions.service.js Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Aug 1, 2022

This pull request introduces 2 alerts when merging 57f17cf into 9e29d3d - view on LGTM.com

new alerts:

  • 2 for Inefficient regular expression

@ericof
Copy link
Contributor Author

ericof commented Aug 1, 2022

@chris48s Good comments, I implemented all of them.

@lgtm-com
Copy link

lgtm-com bot commented Aug 1, 2022

This pull request introduces 2 alerts when merging 10d027b into 9e29d3d - view on LGTM.com

new alerts:

  • 2 for Inefficient regular expression

Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍
8 for the price of one

@lgtm-com
Copy link

lgtm-com bot commented Aug 1, 2022

This pull request introduces 2 alerts when merging 0ef8c12 into 9e29d3d - view on LGTM.com

new alerts:

  • 2 for Inefficient regular expression

@chris48s chris48s merged commit fbb2ff3 into badges:master Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants