[CTAN] fallback to date if version is empty #9036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
chris48s
reviewed
Mar 28, 2023
services/ctan/ctan.service.js
Outdated
|
|
||
| const schema = Joi.object({ | ||
| license: Joi.array().items(Joi.string()).single(), | ||
| version: Joi.object({ | ||
| number: Joi.string().required(), | ||
| number: Joi.string().allow('').required(), | ||
| date: Joi.string().allow(''), |
There was a problem hiding this comment.
if we expect this to be present in the response but set to empty string to indicate "not set" then yes it should be .required()
There was a problem hiding this comment.
In https://github.com/muzimuzhi/shields/commit/80c1fe94c9106659ec010d6b5247edb103f8a377 I added .required() to date without adding date entry to tests. Surprisingly, all checks passed. Is this the expected result?
There was a problem hiding this comment.
Seems it's because not all workflows are triggered by pushing to my fork. date entries are required.
chris48s
added
service-badge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm new to node.js, hence this PR is more or less an imitation of existing code in the same repo.
Do you suggest to make
version.dateinschemaalso required?Update: I did a test in https://github.com/muzimuzhi/shields/commit/80c1fe94c9106659ec010d6b5247edb103f8a377. Surprisingly, without adding
date: "..."to examples and tests, all checks passed.Fixes #9017