[BitbucketLastCommit] Add Bitbucket last commit #10043
Conversation
ReubenFrankel
changed the title
|
|
It would be possible split this current implementation into separate branch and non-branch variations (like the GitHub and Gitea last commit API), but as far as I can see this would require an preliminary request to
{
"mainbranch": {
"name": "main",
"type": "branch"
}
}Happy to implement, but let me know what you think. |
|
🚀 Updated review app: https://pr-10043-badges-shields.fly.dev |
chris48s
added
the
service-badge
Given BitBucket doesn't give us a way to get the default branch without making an extra request, I think it is fine to just say branch is a required param. That is what we have done for the BitBucket Pipelines badge. |
| }).required() | ||
|
|
||
| const queryParamSchema = Joi.object({ | ||
| path: Joi.string().uri({ relativeOnly: true }), |
There was a problem hiding this comment.
once we merge the other related PR, this could become relativeUri, right?
| }, | ||
| }, | ||
| schema, | ||
| httpErrors: { 403: 'private repo' }, |
There was a problem hiding this comment.
could we give a custom 404 error here as well to explain what wasn't found in this case
| const data = await this.fetch({ user, repo, branch, path }) | ||
| const [commit] = data.values | ||
|
|
||
| if (!commit) throw new NotFound() |
There was a problem hiding this comment.
..and then also here. Probably 'no commits found' for this case
Co-authored-by: chris48s <chris48s@users.noreply.github.com>
ReubenFrankel
force-pushed
the
bitbucket-last-commit
branch
from
77db9ea
to
e289228
Compare
|
🚀 Updated review app: https://pr-10043-badges-shields.fly.dev |
|
nice - thanks 👍 |
Add support for Bitbucket last commit: https://developer.atlassian.com/cloud/bitbucket/rest/api-group-commits/#api-repositories-workspace-repo-slug-commits-revision-get