improve performance of [GithubLastCommit] [GitlabLastCommit] [GiteaLastCommit] #10046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris48s
added
the
service-badge
|
| @@ -106,7 +106,7 @@ export default class GithubLastCommit extends GithubAuthV3Service { | |||
|
|
|||
| async handle({ user, repo, branch }, queryParams) { | |||
| const { path, display_timestamp: displayTimestamp } = queryParams | |||
| const body = await this.fetch({ user, repo, branch, path }) | |||
| const body = await this.fetch({ user, repo, branch, path, per_page: 1 }) | |||
There was a problem hiding this comment.
Does this not need to go in fetch here like your GitLab change?
There was a problem hiding this comment.
good catch! thanks for the review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something I noticed while I was testing #10041
It isn't a new problem introduced by that PR, so I decided not to scope creep it there.
Basically the deal here is we only care about the most recent commit, but we're requesting an entire page of results to just use the first object. Only requesting the most recent one means we can request less data from the upstream and render the badge faster. Note this optimisation doesn't work in all situations. Specifically, Gitea ignores limit when the path param is also supplied (see https://docs.gitea.com/api/1.20/#tag/repository/operation/repoGetAllCommits ), but we might as well do this whenever we can.
Note that @ReubenFrankel has already applied the equivalent optimisation in #10043 👍 which adds the corresponding BitBucket badges.