Convert branch to a required param on bitbucketpipelines gitlab travisphpversion #5318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this and all the other work to incorporate the branch change stuff 👍 I'll take a look at this one later today if no one beats me to it |
|
|
||
| t.create('Pipeline status').get('/gitlab-org/gitlab.json').expectBadge({ | ||
| t.create('Pipeline status').get('/gitlab-org/gitlab/v10.7.6.json').expectBadge({ |
There was a problem hiding this comment.
Can we safely assume this will be a long-lived branch?
Edit: I guess so since that's what was there before 😆
PyvesB
approved these changes
Jul 14, 2020
chris48s
changed the title
This was referenced Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #5241
refs #5215
Following up on #5241 (comment) This PR converts
:branchto a required param with a legacy redirect for the "branchless" route to.../masterfor BC. This shows:branchas a required param in the front-end while maintaining backwards-compatibility for existing users.Note one of the the GitLab tests will be failing due to #5282 which is a a different problem - not new in this PR.
Once we are happy with this, I think we should just edit the title so we don't run the gitlab tests, merge this and treat #5282 as a separate unrelated issue.