Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CORS Header to every request #4171

Merged
merged 4 commits into from
Oct 13, 2019
Merged

Add CORS Header to every request #4171

merged 4 commits into from
Oct 13, 2019

Conversation

TagnumElite
Copy link
Contributor

In Issue #3273 Prouser123 said to just Access-Control-Allow-Origin: * have as a header to every request.

I did exactly that. I have confirmed that this works by using an heroku app and a workshop file running the changes.

I don't know whether or not this is the correct method but it works for me.

@shields-ci
Copy link

shields-ci commented Oct 13, 2019 •
edited
Loading

Messages
📖 ✨ Thanks for your contribution to Shields, @TagnumElite!

Generated by 🚫 dangerJS against d27281f

paulmelnikow
paulmelnikow reviewed Oct 13, 2019
View reviewed changes
Copy link
Member

@paulmelnikow paulmelnikow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

Could you add a test in server.spec that this header is set on the response?

@paulmelnikow paulmelnikow added the core Server, BaseService, GitHub auth label Oct 13, 2019
@calebcartwright calebcartwright changed the title Add CORS Header to every request Add CORS Header to every request, run all tests [*****] Oct 13, 2019
@calebcartwright calebcartwright changed the title Add CORS Header to every request, run all tests [*****] Add CORS Header to every request Oct 13, 2019
@TagnumElite
Add test for cors headers
be72d7f 
Also add link to issue
@calebcartwright calebcartwright merged commit b8d0ec4 into badges:master Oct 13, 2019
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@paulmelnikow paulmelnikow mentioned this pull request Oct 14, 2019
Closed
3 tasks
@TagnumElite TagnumElite deleted the cors branch October 14, 2019 06:05
calebcartwright added a commit that referenced this pull request Oct 26, 2019
@calebcartwright
refactor: revert cors header injection #4171
ef702a1
repo-ranger bot pushed a commit that referenced this pull request Oct 26, 2019
@calebcartwright @repo-ranger
refactor: revert cors header injection #4171 (#4253)
5f3a893
@calebcartwright calebcartwright mentioned this pull request Oct 27, 2019
Merged
calebcartwright added a commit that referenced this pull request Oct 27, 2019
@calebcartwright
fix: restore cors header injection from #4171
61318f4
@calebcartwright calebcartwright mentioned this pull request Oct 27, 2019
Merged
calebcartwright added a commit that referenced this pull request May 22, 2020
@calebcartwright
fix: restore cors header injection from #4171
acbefa9
calebcartwright added a commit that referenced this pull request Dec 2, 2021
@calebcartwright
fix: restore cors header injection from #4171
044ba82
calebcartwright added a commit that referenced this pull request Dec 5, 2021
@calebcartwright
restore cors header injection from #4171, run [npm travis] (#4255)
38c1e2d 
* fix: restore cors header injection from #4171

* tests: move test into describe

* prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulmelnikow paulmelnikow paulmelnikow approved these changes

Assignees
No one assigned
Labels
core Server, BaseService, GitHub auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TagnumElite @shields-ci @paulmelnikow @calebcartwright