Allow links only for social badges, affects [GitHubMilestone Dependabot] #6159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PyvesB
added
service-badge
|
chris48s
reviewed
Feb 7, 2021
| @@ -58,7 +58,6 @@ module.exports = class DependabotSemverCompatibility extends BaseJsonService { | |||
| return { | |||
| color: json.colour, | |||
| message: json.status, | |||
| link: this._getLink({ packageManager, dependencyName }), | |||
There was a problem hiding this comment.
Do we still need to keep the _getLink() function itself? Seems like we could remove it..
There was a problem hiding this comment.
Indeed, had missed it, good catch.
|
This pull request introduces 1 alert when merging a5393da into 18dceec - view on LGTM.com new alerts:
|
|
sorry - one more request. Can we add a line to this section of docs https://github.com/badges/shields/blob/master/CONTRIBUTING.md#badge-guidelines saying default links are always off for non-social badges |
chris48s
approved these changes
Feb 7, 2021
|
Deployed to production and communication on Twitter and Discord done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6096.
Twitch is also another badge that doesn't follow this, however, I'm suggesting #6158 as a resolution instead.