Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes some keyboard issues #115

Merged
merged 1 commit into from
Apr 20, 2016

Conversation

diegosanchezr
Copy link
Contributor

@diegosanchezr diegosanchezr commented Apr 20, 2016

Fixes:
A)

  1. Go to a chat conversation
  2. Tap on textfield to open keyboard
  3. Press return multiple times (until the textfield grows enough to show scroll indicators, and touches the navigation bar)
  4. Reveal/Hide the predictive text bar above the keyboard

iOS 8: Keyboard moves up and down
iOS 9: App hangs due to infinite layout loop

B)
Steps as in A)
iOS 8: Keyboard jumps and creates a small gap at the bottom of the screen.
iOS 9: Cursor jumps slightly (not fixed)

C)

  1. Go to a chat conversation
  2. Tap on textfield to open keyboard
  3. Paste a very long text (so textfield grows enough to show scroll indicators, and touches the navigation bar)
  4. Select all text and remove
  5. Paste again

iOS 8: Broken position for keyboard + textfield. Keyboard and textfield may appear in the middle of the screen for example
iOS 9: Broken textfield. It is not scrollable and can only see part of text. If you edit the text (remove a letter), then it fixes the issue and you can now scroll.

D)

  1. Go to a chat conversation
  2. Tap on textfield to open keyboard
  3. Open Chinese (Traditional) - Zhuyin keyboard
  4. Open full-screen chinese keyboard ( tap on ^ )
  5. Drag the keyboard down by swiping down

Full-screen chinese keyboard will be misplaced with close arrow ( v ) not visible

Other related issues not fixed here

E)

  1. Go to a chat conversation
  2. Tap on textfield to open keyboard
  3. Paste very long text (so textfield grows enough to show scroll indicators, and touches the navigation bar)
  4. Open Chinese (Traditional) - Zhuyin keyboard
  5. Open full-screen chinese keyboard ( tap on ^ )
  6. Drag the keyboard down by swiping down

Full-screen chinese keyboard will be misplaced. It will be in the middle of the screen ( looks like as much as the textfield grows once it's placed at the bottom )

F)

  1. Go to a chat conversation
  2. Tap on textfield to open keyboard
  3. Long press on a text message with a date
  4. Choose "Create event" from action sheet
  5. In the create event screen dismiss the keyboard
  6. Cancel event creation

Input field is placed in the middle of the screen

@codecov-io
Copy link

Current coverage is 64.89%

Merging #115 into dev will increase coverage by +0.74% as of 425ec5f

@@              dev    #115   diff @@
=====================================
  Files          60      60       
  Stmts        3125    3131     +6
  Branches        0       0       
  Methods         0       0       
=====================================
+ Hit          2005    2032    +27
  Partial         0       0       
+ Missed       1120    1099    -21

Review entire Coverage Diff as of 425ec5f

Powered by Codecov. Updated on successful CI builds.

@diegosanchezr diegosanchezr changed the title [WIP]Fixes some keyboard issues Fixes some keyboard issues Apr 20, 2016
@diegosanchezr diegosanchezr merged commit acc9900 into badoo:dev Apr 20, 2016
@diegosanchezr diegosanchezr mentioned this pull request Apr 20, 2016
@diegosanchezr diegosanchezr deleted the fixes-keyboard-issues branch April 20, 2016 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants