Minor performance improvements for TextBubble #166
Merged
+75
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegosanchezr
changed the title
- Avoids updating font and color in TextBubble if it's not needed: would make attributed text to update - Avoids updating views in selected setter if value didn't change (setter is called by the collection view as part of dequeuing) - Avoids creating dictionary of attributes all the time for date attributed string (for some reason this was appearing in profiling with some swift-to-objc conversions) Uses enum as image key in text style for greater safety.
diegosanchezr
force-pushed
the
textbubble-minor-performance-improvements
branch
from
1b570e3
to
40856a6
Compare
Current coverage is 65.34%@@ dev #166 diff @@
==========================================
Files 61 61
Lines 3308 3310 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 2162 2163 +1
- Misses 1146 1147 +1
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor performance improvements:
Uses enum as image key in text style for greater safety.