Allows a datasource to return different chatItem instances for same message id #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, due to the mapping between chatItem instance and presenter, a new presenter would be created. This fixes:
This introduces ChatItemCompanion, a structure which attaches a ChatItem with its presenter and decoration attributes. This solves 1) and 2)
Still, a new presenter will be created if a different instance is returned by the datasource for a same message id. This will cause its internal state to be lost, so it's recommended not to keep any state in the presenter, or use an external storage to be able to recover it. We might revisit this in the future by reusing same presenters for same uids or adding API to copy state from one presenter to a new one.