Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input bar delegation #50

Merged
merged 4 commits into from
Mar 7, 2016
Merged

Input bar delegation #50

merged 4 commits into from
Mar 7, 2016

Conversation

AntonPalich
Copy link
Contributor

ChatInputBarDelegate has been used for internal purposes, but now it purpose is to notify external users about UI events (requested in #40). ChatInputBar notifies its presenter using direct method calls (classic MVP pattern) instead of using delegation pattern.

@AntonPalich
Copy link
Contributor Author

@diegosanchezr Please, take a look

@codecov-io
Copy link

Current coverage is 62.03%

Merging #50 into dev will increase coverage by +0.06% as of 90d0f93

@@              dev     #50   diff @@
=====================================
  Files          57      57       
  Stmts        2819    2824     +5
  Branches        0       0       
  Methods         0       0       
=====================================
+ Hit          1747    1752     +5
  Partial         0       0       
  Missed       1072    1072       

Review entire Coverage Diff as of 90d0f93

Powered by Codecov. Updated on successful CI builds.

diegosanchezr added a commit that referenced this pull request Mar 7, 2016
@diegosanchezr diegosanchezr merged commit 37af708 into badoo:dev Mar 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants