Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presenter factory #89

Merged
merged 2 commits into from
Mar 27, 2016
Merged

Presenter factory #89

merged 2 commits into from
Mar 27, 2016

Conversation

weyg
Copy link

@weyg weyg commented Mar 27, 2016

  • introduced presenter factory protocol
  • moved presenterBuilders based functionality into a BaseChatItemPresenterFactory
  • introduced new method for subclasses public func createPresenterFactory(); by default creates BaseChatItemPresenterFactory and initilizes it with presenterBuilders returned by self.createPresenterBuilders()
  • fixed warning for selector of addIncomingMessageButton

alatypov and others added 2 commits March 26, 2016 10:40
* introduced presenterFactory
* moved presenterBuilders inside of BasePresenterFactory
@codecov-io
Copy link

Current coverage is 64.42%

Merging #89 into dev will increase coverage by +0.09% as of c225f82

@@              dev     #89   diff @@
=====================================
  Files          57      57       
  Stmts        3039    3047     +8
  Branches        0       0       
  Methods         0       0       
=====================================
+ Hit          1955    1963     +8
  Partial         0       0       
  Missed       1084    1084       

Review entire Coverage Diff as of c225f82

Powered by Codecov. Updated on successful CI builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants