Add source parameter to the connection #66
Merged
+274
−202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions-refactor
ShikaSD
force-pushed
the
connections-refactor
branch
from
eca37d8
to
d60aa18
Compare
zsoltk
reviewed
Apr 8, 2019
| import com.badoo.mvicore.element.Reducer | ||
| import com.badoo.mvicore.element.WishToAction | ||
| import com.badoo.mvicore.consumer.wrapWithMiddleware | ||
| import com.badoo.mvicore.element.* |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Connectionclass we have right now is somehow limited for external observer (any middleware).If you apply transformer, the only source the middleware will receive is
ObservableFlatMapwhich is far from ideal.This pull request tries to fix this issue, updating type signature to
Connection<Out, In>, adding parameters for source and transformer and updating built-in middlewares to work with current implementation.This PR does break backward compatibility for
Connectionusages, but I could not find any in our codebase, so I conclude it is not explicitly broadly used.