Configure detekt #227
Merged
Configure detekt #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Suppressed some issues. |
|
Merge after #233 |
# Conflicts: # reaktive/src/iosCommonMain/kotlin/com/badoo/reaktive/scheduler/MainScheduler.kt # reaktive/src/nativeCommonMain/kotlin/com/badoo/reaktive/scheduler/CreateTrampolineScheduler.kt # utils/src/jsMain/kotlin/com/badoo/reaktive/utils/clock/DefaultClock.kt
|
Ready to merge. |
arkivanov
reviewed
Oct 13, 2019
| @@ -127,6 +129,7 @@ fun <T1, T2, T3, T4, R> combineLatest( | |||
| mapper(values[0] as T1, values[1] as T2, values[2] as T3, values[3] as T4) | |||
| } | |||
|
|
|||
| @Suppress("LongParameterList") | |||
There was a problem hiding this comment.
Let's disable this inspection please
| @@ -9,6 +11,7 @@ import com.badoo.reaktive.utils.atomic.update | |||
| import com.badoo.reaktive.utils.replace | |||
| import com.badoo.reaktive.utils.serializer.serializer | |||
|
|
|||
| @Suppress("ComplexMethod") | |||
There was a problem hiding this comment.
And perhaps this should be disabled as well?
| @@ -9,6 +9,7 @@ internal abstract class SerializerImpl<in T>(queue: Queue<T>) : Serializer<T> { | |||
| private val monitor = Any() | |||
| private var isDraining = false | |||
|
|
|||
| @Suppress("ReturnCount") | |||
There was a problem hiding this comment.
What about this one? Do we really want it?
There was a problem hiding this comment.
return X count in one method.
|
I wanted to discuss it in person, but forgot.
|
arkivanov
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #204
Still long path to fix / ignore every issue.