fix build by using sources and linking with libmysqlservices.a #5
Conversation
| mkdir /home/builder/rpm && \ | ||
| chown -R builder /home/builder | ||
|
|
||
| USER builder |
There was a problem hiding this comment.
@mkevac what was the goal of the dedicated user and why we can do it under current?
There was a problem hiding this comment.
rpmbuild refuses to build as a root user
|
|
||
| RUN mkdir -p /_src && cd /_src && \ | ||
| git clone https://github.com/anton-povarov/pinba2 && \ | ||
| # git clone --branch=fix_lib https://github.com/mkevac/pinba2 && \ | ||
| git clone https://github.com/badoo/pinba2 && \ |
There was a problem hiding this comment.
@mkevac oh now this is official but git clone should be replaced with COPY, but I will take care of it in:
Please consider updating links to new repo / web page here:
There was a problem hiding this comment.
Yes, there are many improvements here that can be made. I wanted to fix build issue first for you to be able to use this thing at all.
There was a problem hiding this comment.
Docs were moved as well:
| @@ -36,7 +36,7 @@ make install | |||
| cd /_src/pinba2 | |||
| ./buildconf.sh | |||
| ./configure --prefix=/_install/pinba2 \ | |||
| --with-mysql=/usr \ | |||
| --with-mysql=/home/builder/rpm/mariadb-10.1.26 \ | |||
There was a problem hiding this comment.
@mkevac this will fail with next release of MariaDB. We should either get the directory name dynamically or explicitly set versions in Dockerfile.
Fixes issue #2
I've removed ability to build with just installed headers.
I am now using mariadb built from sources (*.src.rpm) in pinba build.
I am now building pinba with libmysqlservices.a needed for some symbols.