Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More languages #8

Open
baetheus opened this issue May 24, 2020 · 1 comment
Open

More languages #8

baetheus opened this issue May 24, 2020 · 1 comment
Assignees
@baetheus

Comments

@baetheus
Copy link
Owner

  • add italian puzzles
  • add settings to show/hide puzzles by language
@baetheus baetheus self-assigned this May 24, 2020
@baetheus
Copy link
Owner Author

baetheus commented Jun 6, 2020

Current game manager is language agnostic and only compares characters in a string via string split(""). To handle unicode we would need to build puzzles by using the string iterator with ... as outlined in the mdn web docs here. As long as the chars array has length 6 and the unicode renders correctly then puzzles with non utf-8 charsets should work.

Additionally, the game model should be expanded to include a language property that is filterable. The games store should be expanded to pull in each game list by language. Settings should get list of checkboxes that enable/disable filtering of puzzles by language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baetheus baetheus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@baetheus