Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weight Validation Inconsistencies #2792

Closed
richmondnursery opened this issue Mar 28, 2020 · 1 comment
Closed

Weight Validation Inconsistencies #2792

richmondnursery opened this issue Mar 28, 2020 · 1 comment
Assignees
@shivam-webkul
Labels
Bug Fixed When bug issue is fixed. Bug Something isn't working.

Comments

@richmondnursery
Copy link

Weight Validations differ between Simple and Configurable Products but should be consistent across the application.

Steps to Reproduce:

  1. Create a new Simple Product.
  2. Weight is validated as numeric.
  3. Create a new Configurable Product.
  4. Under variants, Weight is validated as numeric > 0.0001.
@vaishaliwebkul vaishaliwebkul added the Bug Something isn't working. label Mar 28, 2020
@shivam-webkul shivam-webkul added Bug Fixed When bug issue is fixed. and removed Bug Fixed When bug issue is fixed. labels Apr 7, 2020
@shivam-webkul shivam-webkul self-assigned this Apr 7, 2020
@shivam-webkul shivam-webkul mentioned this issue Apr 7, 2020
Merged
@shivam-webkul shivam-webkul added the Bug Fixed When bug issue is fixed. label Apr 7, 2020
jitendra-webkul added a commit that referenced this issue Apr 7, 2020
@jitendra-webkul
Merge pull request #2841 from shivam-webkul/master
3ddb6a5 
issue #2792 resolved
@vaishaliwebkul
Copy link

@richmondnursery
This issue has been fixed, If you're still getting same issue feel free to reopen.

AnnikaWolff added a commit to Haendlerbund/bagisto that referenced this issue May 7, 2020
@AnnikaWolff @dependabot
@shubh-mehrotra @jitendra-webkul @rahulcs0082 @thyseus @shivam-webkul @0xuhe @VaD1ke @cagartner @chemisax @vivek-webkul @Namvarii @SteffenMahler @MattApril
Bagisto to HB Update (#23)
41754f4 
* Bump symfony/http-foundation from 4.4.5 to 4.4.7

Bumps [symfony/http-foundation](https://github.com/symfony/http-foundation) from 4.4.5 to 4.4.7.
- [Release notes](https://github.com/symfony/http-foundation/releases)
- [Changelog](https://github.com/symfony/http-foundation/blob/master/CHANGELOG.md)
- [Commits](symfony/http-foundation@v4.4.5...v4.4.7)

Signed-off-by: dependabot[bot] <support@github.com>

* remove line

* bagisto#2808

* bagisto#2785

* checkout page margin added

* {git commit -m

* checkout page issue

* modal view update

* bundled assets

* remove irrelevant css

* bagisto#2775

* remove irrelevant xhr

* revert back changes in format price

* category call get products method

* customer options click issue resolved

* customer panel accordian view and file picker view

* customer accordian design update

* Issue bagisto#2812

* compare page update height after loading images

* api changes

* code changed for api

* bagisto#2329

* issue bagisto#2792 resolved

* margin added between wishlist icon and compare icon

* checkout page email validation

* bagisto#2834

* Issue bagisto#2713 fixed

* Issue bagisto#2851 fixed

* Issue bagisto#2847

* Issue bagisto#2851 fixed

* Issue bagisto#2768 fixed

* bagisto#2691

* Issue bagisto#2794

* bagisto#2849

* bagisto#2856

* Changelog updated

* subcategory visibility issue in responsive

* bagisto#2790

* Issue bagisto#2793

* Issue bagisto#2846 fixed

* Changelog updated

* Fixed date icon issue

* Translate mass-update for review status in admin grid

* Fix save-category btn translation for langs with noun case

* Added more view_render_events in the customer account views

* Added view_render_event to admin order view

* Created new view_render_events for admin order and invoice view

* bagisto#2866

* calculate height on change value of dropdown

* bagisto#2876

* Issue bagisto#2784 fixed

* Updated changelog

* Issue bagisto#2871 fixed

* Issue bagisto#2543 fixed

* subcategory issue resolved

* Updated changelog

* bagisto#2875

* Issue bagisto#2890

* 2875 update

* remove channel from tax category

* introduce channel and channel inventory source factories

* Issue bagisto#2895

* removed dd

* Issue bagisto#2893

* add unified address-table and handling for models

* Issue bagisto#2884

* Issue bagisto#2863 fixed

* fix address_type at many places; add tests for address relations

* Issue bagisto#2793

* Issue bagisto#2721

* fix address-constrains; fix address global scopes

* variant products images update issue resolved

* rename address types

* responsive cart count update

* bagisto#2915

* fix typo in address migration

* update

* update

* add option to OrderItemFactory to use existing product

* Added new events to customer update and checkou, fixed some view render events and pt_BR grammar

* Add Japanese translation

* Moved command to packages

* Updated composer lock file

* Bump symfony/http-foundation from 4.4.5 to 4.4.7

Bumps [symfony/http-foundation](https://github.com/symfony/http-foundation) from 4.4.5 to 4.4.7.
- [Release notes](https://github.com/symfony/http-foundation/releases)
- [Changelog](https://github.com/symfony/http-foundation/blob/master/CHANGELOG.md)
- [Commits](symfony/http-foundation@v4.4.5...v4.4.7)

Signed-off-by: dependabot[bot] <support@github.com>

* bagisto#2908

* customer sidebar menu issue resolved

* removed layered navigation in searchproducts page

* bagisto#2919

* content header path update

* add check if view exists

* [Updated: getBaseImage() method updated for configurable product.]

* Cancel feature added in customer order

* Installer fixes

* resolved issue with product images carousel

* change file name from views to Views

* Auto exchange rate feature added

* fix category issue and change country,state order

* max price issue in category

* Updated change log file

* Updated change log file

* fix translation in add attribute button

fix add button not translated to other language.

* Issue bagisto#2954 fixed

* Removed unnecessary code from CartController

* Issue bagisto#2954 fixed

* Issue bagisto#2945 fixed

* Updated change log file

* Updated change log file

* Version updated in env files

* add CartRuleCest

* introduce channel and customer group filter for cart rule grid

* fix calulation helper in test

* Issue bagisto#2949 and bagisto#2950

* resolve issue 2964

* localization error message added in velocity theme

* type hint changed

* refactoring, variable renamed

* Issue bagisto#2942

* Issue bagisto#2942

* configuration added for favicon in admin

* Issue bagisto#2969

* bagisto#2974

* favicon for admin login

* fix randomly failing tax cest

* remove unnecessary use statements

* fix GuestCheckoutCest

* remove newline

* set price faker in Laravel5Helper to 2 decimals, fix rounding in CartTaxesCest too

* Added missing space for configurable/grouped product price.

* responsive product gallery issue resolved

* Issue bagisto#2987

* Issue bagisto#2987

* Product multiple image select feature added

* Order comment feature added

* process checkout if user not logged in

* Order comment email sent to customer

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Shubham Mehrotra <shubh0896m@gmail.com>
Co-authored-by: Jitendra Singh <39991107+jitendra-webkul@users.noreply.github.com>
Co-authored-by: rahulshukla-home <rahulcs0082@gmail.com>
Co-authored-by: Herbert Maschke <thyseus@gmail.com>
Co-authored-by: shivam kumar <shivam.kumar174@webkul.com>
Co-authored-by: Shivam kumar <50355852+shivam-webkul@users.noreply.github.com>
Co-authored-by: hexu <hexu.garfield@gmail.com>
Co-authored-by: Pranshu Tomar <pranshutomar@Pranshus-MacBook-Air.local>
Co-authored-by: VaD1ke <vl.slesarenko@gmail.com>
Co-authored-by: Carlos Augusto Gartner <contato@carlosgartner.com.br>
Co-authored-by: Florian Bosdorff <florian.bosdorff@haendlerbund.de>
Co-authored-by: José María Campaña <chemisax@gmail.com>
Co-authored-by: Vivek <viveksh047@webkul.com>
Co-authored-by: namvarii <50305913+namvarii@users.noreply.github.com>
Co-authored-by: Steffen Mahler <steffen.mahler@haendlerbund.de>
Co-authored-by: Herbert Maschke <thyseus@pm.me>
Co-authored-by: SteffenMahler <57138594+SteffenMahler@users.noreply.github.com>
Co-authored-by: Matt April <matthew.japril@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shivam-webkul shivam-webkul

Labels
Bug Fixed When bug issue is fixed. Bug Something isn't working.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vaishaliwebkul @shivam-webkul @richmondnursery