Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bubbled scrollwheel events #3

Closed
cycle4passion opened this issue Feb 19, 2022 · 6 comments
Closed

Bubbled scrollwheel events #3

cycle4passion opened this issue Feb 19, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@cycle4passion
Copy link

cycle4passion commented Feb 19, 2022

They appear to be recognized, but do not fire page scroll functionality.

https://codepen.io/c4p/pen/ZEaxbxx?editors=1111

@cycle4passion cycle4passion changed the title Bubbled scrollwheel events not capturing in scrollpage-js Bubbled scrollwheel events Feb 19, 2022
@bagusindrayana bagusindrayana added the bug Something isn't working label Feb 24, 2022
@bagusindrayana
Copy link
Owner

thanks for the report and sorry for the late reply, for now the cause of the bug is if the "page" element of "main-page" has a child, I've found the solution and now testing it for scroll function on desktop and touch/swipe function on mobile and will be fixed in the next update

@bagusindrayana
Copy link
Owner

I've released version 0.1.3 and it's fixed (I've tried it on desktop and mobile, maybe need to try in some cases and conditions), you can try it and if there are other problems please report me I will try to fix it.

In the future I will make some better examples using all the features available.

@cycle4passion
Copy link
Author

cycle4passion commented Feb 26, 2022

Works for the previous example above, but does not accomodate overflow: scroll in div. Not sure if you wanted to cover that or not. Most of the other pagescroll utils allow you to scroll over div but when it reaches end scrollpage fired.

Codepen

If you decide to implement, it might be worthy of another setting, something like "allowChildrenToScroll" defaulting to true, but if set to false scrollpage-js changes pages immediately (as currently).

@bagusindrayana
Copy link
Owner

thank you for the suggestions and reports I will soon add some features in the future to cover the shortcomings of this library

@bagusindrayana
Copy link
Owner

Works for the previous example above, but does not accomodate overflow: scroll in div. Not sure if you wanted to cover that or not. Most of the other pagescroll utils allow you to scroll over div but when it reaches end scrollpage fired.

Codepen

If you decide to implement, it might be worthy of another setting, something like "allowChildrenToScroll" defaulting to true, but if set to false scrollpage-js changes pages immediately (as currently).

i already make demo with scrolling content for next version

@bagusindrayana
Copy link
Owner

Works for the previous example above, but does not accomodate overflow: scroll in div. Not sure if you wanted to cover that or not. Most of the other pagescroll utils allow you to scroll over div but when it reaches end scrollpage fired.

Codepen

If you decide to implement, it might be worthy of another setting, something like "allowChildrenToScroll" defaulting to true, but if set to false scrollpage-js changes pages immediately (as currently).

i try fix in v0.1.4 all children will be able scrolling if have overflow and add options triggerScrollChildren this will trigger scrollpage if scrolling content reach bottom or top (default false)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants