Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parent and previous sibling content not respected on scrollback #4

Closed
cycle4passion opened this issue Feb 27, 2022 · 2 comments
Closed

Comments

@cycle4passion
Copy link

Thank you for your effort. I appreciate the small, and not overly complicated package. I think it is a few minor improvements from being a valuable resource. Nice job.

but... I found another issue.

Codepen

If in a layout such as

<div>PARENT
  <div>PREVIOUS SIBLING</div>
  <div id="main-page">
    <div  id="page1"></div>
    <div  id="page2"></div>
    <div  id="page3"></div>
  </div>
</div>

scrolling down, then back up does not show PARENT or PREVIOUS SIBLING and they stay inaccessible. I probably is reasonable to require main-page to be first child below a parent, but the parent should be respected (pun intended).

@bagusindrayana
Copy link
Owner

thank you i already update demo page with header and footer is outside from "main-page", but I haven't released the latest version yet i need to fix and add some other features, i also add some another example like scroll content and dynamic height

@bagusindrayana
Copy link
Owner

fix in v0.1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants