Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response vector #8

Closed
lgalardini opened this issue Mar 2, 2020 · 1 comment · Fixed by #9
Closed

Response vector #8

lgalardini opened this issue Mar 2, 2020 · 1 comment · Fixed by #9
Assignees
Labels

Comments

@lgalardini
Copy link
Contributor

Hello everyone,

In main.cpp the following code
//Sorting keypoints by deacreasing order of strength vector<**int**> responseVector; for (unsigned int i =0 ; i<keyPoints.size(); i++) responseVector.push_back(keyPoints[i].response);

Since the response of a cv::Keypoint is a float value, I think that the responseVector should be float as well instead of int. In fact, if other detectors than FAST are used, the response vector is going to be populated of zeros because the range is different.

@BAILOOL BAILOOL added the bug label Mar 2, 2020
@BAILOOL
Copy link
Owner

BAILOOL commented Mar 2, 2020

@lgalardini you are right. it is a bug. cv::KeyPoint::response returns float . Reference.

I will fix it whenever I have time. Meanwhile, since you discovered this, you can create Pull request for this issue. Thank you for your contribution to the project!

@BAILOOL BAILOOL assigned BAILOOL and lgalardini and unassigned BAILOOL Mar 2, 2020
@BAILOOL BAILOOL linked a pull request Mar 2, 2020 that will close this issue
@BAILOOL BAILOOL closed this as completed in #9 Mar 2, 2020
BAILOOL added a commit that referenced this issue Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants