Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ItemNameAdapter18 issue on MC 1.18.1 #106

Closed
TheBusyBiscuit opened this issue Dec 17, 2021 · 8 comments
Closed

ItemNameAdapter18 issue on MC 1.18.1 #106

TheBusyBiscuit opened this issue Dec 17, 2021 · 8 comments

Comments

@TheBusyBiscuit
Copy link
Member

https://pastebin.com/4Mnz5ZER
@TheBusyBiscuit TheBusyBiscuit mentioned this issue Dec 17, 2021
Merged
16 tasks
@WalshyDev
Copy link
Member

WalshyDev commented Dec 17, 2021 •
edited
Loading

It looks like it's still getDisplayName on Spigot 1.18.1
image

Can also confirm, I am not getting this exception on Spigot 1.18.1 and the latest commit of wip/1.18 in SF repo

@TheBusyBiscuit
Copy link
Member Author

Yeah but why can the method not be found

@WalshyDev
Copy link
Member

It's found for me. I had no issues.

@TheBusyBiscuit
Copy link
Member Author

Did you test this branch?
Slimefun/Slimefun4#3369

@WalshyDev
Copy link
Member

Yep, using commit f0bf6f0d1d24024671aebd3c3021a15cdb5819fd

@TheBusyBiscuit
Copy link
Member Author

weird.
What did you do to trigger this method?

@WalshyDev
Copy link
Member

Ok, hadn't done too much. Yeah... got it to fire on the pedestal. That's weird...

I can debug it in ~30-60 mins

@TheBusyBiscuit
Copy link
Member Author

Yeah... got it to fire on the pedestal. That's weird...

Exactly! I'm not really getting why.

I can debug it in ~30-60 mins

Thanks!

TheBusyBiscuit added a commit that referenced this issue Dec 17, 2021
@TheBusyBiscuit
Merge pull request #107 from baked-libs/fix/106
8d07d14 
Closes #106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheBusyBiscuit @WalshyDev