F/fix warnings #310
Merged
F/fix warnings #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of open-coding the optional libsyslog-ng-crypto as a dependency use $(CRYPTO_LIBS) which conditionally contains the same if libsyslog-ng-crypto is built. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Due to a stray colon, the grammar contained a conflict as both source_systemd_syslog_option and its recursive parent source_systemd_syslog_options permitted an empty evaluation. By removing the extra colon, only the "options" rule allows the empty match, which in turn removes the conflict. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
…atching character signs The types used for detecting the message boundaries were not consistently used and some of the call-sites lacked type-casts. This patch fixes that up by consistently using guchar * for detecting line endings, and only casting it to a gchar * when passing it on to pcre. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
The test program contained a function that was named like as it was part of the LogPipe API, called log_pipe_queue_with_default_path_options(). call that invoke_rewrite_rule() instead, that reflects its purpose much better. If we need the API extension, we should do that in the core. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
HofiOne
pushed a commit
to HofiOne/syslog-ng
that referenced
this pull request
Sep 26, 2024
Signed-off-by: László Várady <laszlo.varady@anno.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix a couple of compilation warnings and a s/r conflict in afsocket grammar.
Please merge!