f/debugger #381
Merged
f/debugger #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
This was entirely unused, so get rid off that. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
The log_source_post() function performs the initial house-keeping for
emitting a message from within a source. This was originally
part of log_source_queue() virtual method.
These are my reasons for extracting that to a separate function:
- log_source_queue() was special, it couldn't call log_msg_drop() before
the house keeping was done
- the log_pipe_queue() wrapper couldn't drop the message either
- this makes the call-sites a bit more difficult having to create
their LogPathOptions instance, which is then basically ignored
- this fixes a SIGABRT if the user drops/quits using the interactive
debugger _before_ log_source_queue() was executed.
By separating this stuff into a separate log_source_post(), everything is
set up first, and then log_source_queue() is just a normal queue() function
without any kind of special treatment.
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
This is a preparatory patch that extracts the creation of LogPipe instances that are automatically created during compilation and not directly related to a configuration element. This patch makes it possible to centralize code that works with this set of LogPipes. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
This function extracts LogMultiplexer creation into a separate function, so that it can be used to centralize related code. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
… to the LogExprNode Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
This patch implements a builtin configuration debugger. Signed-off-by: Balazs Scheidler <balazs.scheidler@balabit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Albeit not entirely ready, this branch already contains a number of small improvements in various areas of syslog-ng that is already useful. (cfg-tree, logmpx, ...)
It also contains the initial work on the interactive debugger, which is just experimental at this point. Less tests than I would have liked, my excuse is that it's interactive code that is tricky to test :) I know it's a lame excuse though.
Anyway, it's better to integrate now, as it rots otherwise in its topic branch.
Please merge, if possible.
thanks