persist-state: Clean up the temporary file upon destroy #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When destroying a persist state, unlink the temporary file too, as to not leave junk behind. Added test cases for both the commit() + destroy() and the cancel() + destroy() cases. With this fixed, the persist files created during make check need not be in CLEANFILES. Signed-off-by: Gergely Nagy <algernon@balabit.hu>
|
are you sure it is a good idea to remove the file if the persist-state object is destroyed? it is the file that contains our current file positions and if it gets removed at shutdown, how would the data in it survive a restart? |
|
It removes the backup file, not the main one. |
|
There is actually a test that verifies that the persist file does not get deleted when it needs to stay. If I break the code, and remove |
|
my bad. I'll merge this then. |
bazsi
added a commit
that referenced
this pull request
Jan 22, 2014
…eanup persist-state: Clean up the temporary file upon destroy
bazsi
pushed a commit
to bazsi/syslog-ng
that referenced
this pull request
May 17, 2024
syslog-ng: install package signing public key after generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When destroying a persist state, unlink the temporary file too, as to
not leave junk behind. Added test cases for both the commit() +
destroy() and the cancel() + destroy() cases. With this fixed, the
persist files created during make check need not be in CLEANFILES.
Signed-off-by: Gergely Nagy algernon@balabit.hu