Don't free StreamWriter buffer until after callbacks

* Some callbacks may want to process the data so we can't free it out from under them.
baldurk · Jun 9, 2023 · 98f2ad0 · 98f2ad0
1 parent 96e39bb
commit 98f2ad0
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/renderdoc/serialise/streamio.cpp b/renderdoc/serialise/streamio.cpp
@@ -771,8 +771,6 @@ StreamWriter::StreamWriter(Compressor *compressor, Ownership own)
 
 StreamWriter::~StreamWriter()
 {
-  FreeAlignedBuffer(m_BufferBase);
-
   if(m_Ownership == Ownership::Stream)
   {
     if(m_File)
@@ -789,6 +787,8 @@ StreamWriter::~StreamWriter()
 
   for(StreamCloseCallback cb : m_Callbacks)
     cb();
+
+  FreeAlignedBuffer(m_BufferBase);
 }
 
 bool StreamWriter::SendSocketData(const void *data, uint64_t numBytes)