-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect the XDG base directory specification’s environment variables #723
Comments
This should be fixed on v1.x now - if Please check this on the latest v1.x nightly build or compile manually from v1.x, and let me know if you have any further issues. |
I just tested, there is still one issue which is when the user manually sets The solution would be to replace |
Is there anything to clarify explicitly what the behaviour should be? The spec isn't worded well, the only time it mentions directories existing or being created is at the end which seems to only refer to It wouldn't be useful to set the dir to something unique or different to any other application, since then the layer wouldn't get picked up by the loader when the vulkan application runs. |
v1.0 has now released, including the change as described above. |
The vulkan shader cache and other files are still stored/expected in |
Shader cache would have to go into |
I was testing renderdoc 1.2 recently, and it still creates If XDG variables are not set, the cache should go into |
The current code creates
At the moment, that line of code from earlier I linked always does:
|
Please do not comment on old issues that have been closed. If you are encountering a bug or are requesting a feature please open a new issue. You can reference this issue if you wish, but opening a new issue prevents any confusion of accidentally linking two unrelated issues and means that each issue can be handled in a clean process. |
As of 177d595, RenderDoc creates a
~/.local/share/vulkan/implicit_layer.d/renderdoc_capture.json
file, no matter the value of$XDG_DATA_HOME
.It should first check the value of
$XDG_DATA_HOME
, if it’s an absolute path create the file in$XDG_DATA_HOME/vulkan/implicit_layer.d/renderdoc_capture.json
, otherwise use the curent path.See https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html#variables for more information.
The text was updated successfully, but these errors were encountered: