Intel GL performance counters #1136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit cba4e8a ("Implemented OpenGL counters using pipeline stats and occlusion queries") introduced a query with the GL_NONE target which doesn't seem valid looking at the OpenGL 4.6 (Core Profile). Section 4.2. QUERY OBJECTS AND ASYNCHRONOUS QUERIES: "An INVALID_ENUM error is generated if target is TIMESTAMP , or is not one of the query object targets described in section 4.2.1." Section 4.2.1 doesn't list GL_NONE.
Avoid error raised when querying the results later on.
A missing \n was triggering a compile error for example : #extension GL_ARB_shader_storage_buffer_object : require#define SHADER_RESTYPE 1 #define UINT_TEX 0
At this point we don't have Intel GL counters. But the current logic assumes there is only AMD ones (and that if it's not AMD's, it must be the generic ones).
djdeath
force-pushed
the
intel-gl-performance-counters
branch
from
28e3e76
to
0bc2cbb
Compare
Intel published a performance query extension support defined back in 2013. This is available on Windows & Linux (in the Mesa driver). This should provide the same types of counters as the MDAPI backend for DX11. Frameretrace [1] (a fork/branch of Apitrace) uses the same extension. [1]: https://github.com/janesma/apitrace/wiki/screen-shots
djdeath
force-pushed
the
intel-gl-performance-counters
branch
from
0bc2cbb
to
fd7ed29
Compare
|
I don't have any objections to adding more counter support within the existing framework, it's just that profiling is not currently a goal of the project as I don't have the time to put into it. So in that respect PRs are fine. I would ask though that you avoid adding dependent PRs like this, otherwise changes and fixes to the other PR on that branch will clash with this one. Once those changes are merged then either re-open this PR with rebased changes or open a new one, but please only one PR at a time unless they're entirely independent. |
|
Reopened as #1202 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the fixes from #1134
It adds the performance counter support on OpenGL for Intel chipsets and in particular the motivation was to get some data with the Intel/Mesa driver (although this extension is available on Windows too).
Reading #967 it seems performance counter support is somewhat low on the list of things to tackle (if it's even on the list).
Just putting this out there, no big deal if no interest.