DXIL Shader Debugger Stubs #3305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DXBC and DXIL Shader Debugger's inherit from "DXBCContainerDebugger : public ShaderDebugger". "DXBCContainerDebugger" has member variable "isDXIL" to be able to choose if DXIL or DXBC ShaderDebugger is active and allow the correct cast from "ShaderDebugger" to be made. Added stub of DXILDebug::Debugger in new files "drivers/shaders/dxil/dxil_debug.[h,cpp]"
The DXIL paths should not be executed and currently populated with error messages that DXIL debugger support is missing.
baldurk
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DXIL Shader Debug paths for
DebugThread/DebugVertex/DebugPixelAdded
DXBCContainerDebuggerto wrap DXBC or DXIL shader debuggerDXBCContainerDebugger : public ShaderDebugger.DXBCContainerDebuggerhas member variableisDXILto be able to choose if DXIL or DXBC ShaderDebugger is active and then used to perform the correct cast fromShaderDebuggertoDXBCDebug::InterpretDebugger *orDXILDebug::Debugger *Added stub of
DXILDebug::Debuggerin new filesdrivers/shaders/dxil/dxil_debug.[h,cpp]Testing
d3d11_shader_debug_zoo&d3d12_shader_debug_zoo