Use Reakit Button for accessibility

[iamsolankiamit]

Change-type: Minor
Signed-off-by: Amit Solanki amit@balena.io

Connects-to: #
See:
Depends-on:
Change-type: major|minor|patch

---

Contributor checklist

• I have rebuilt the README with npm run build:docs
• I have regenerated screenshots for any affected components with npm run generate-screenshots
• I have regenerated jest snapshots for any affected components with npm run jest -- -u

Reviewer Guidelines

• When submitting a review, please pick:
  • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
  • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
  • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

---

[LucianBuzzo]

@iamsolankiamit I'm heavily opposed to doing this, as we would end up with a situation where we are using two different UI libraries as a skeleton instead of just Grommet. Can we instead send a PR to Grommet to make the Grommet button WAI ARIA compliant?

[iamsolankiamit]

Sure @LucianBuzzo I can do that, I just wanted to highlight here the ease of making things accessible.

[LucianBuzzo]

@iamsolankiamit If you open a PR to highlight a specific issue, please take some time to add a message in the commit body or the text area in GitHub. It's very hard for others to infer context or meaning just from code changes. Taking a few minutes to express your thoughts is extraordinarily helpful.

[sradevski]

Let's just close this, and do a top-down approach to accessibility instead, as we discussed earlier. Once we see what issues the current implementation has, we can think of possible solutions (whether that is improving grommet, adding support to rendition components, etc.)