Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

models.device.reboot errors with DeviceNotFound when the device is offline #649

Open
thgreasi opened this issue Mar 19, 2019 · 1 comment
Open

models.device.reboot errors with DeviceNotFound when the device is offline #649

thgreasi opened this issue Mar 19, 2019 · 1 comment
Labels
bug possibly-breaking-change

Comments

@thgreasi
Copy link
Member

/supervisor/v1/reboot is (atm) the only supervisor endpoint that we are doing .catch(notFoundResponse, treatAsMissingDevice(uuidOrId)).
We should not silence Request error: No online device(s) found what that's what is returned and still be able to properly detect DeviceNotFound errors both when calling it with an ID or UUID.
@srlowe srlowe mentioned this issue Jun 18, 2020
Open
@srlowe
Copy link

srlowe commented Sep 17, 2020

Same for device.restartApplication I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug possibly-breaking-change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thgreasi @srlowe