Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the determined uncompressed size on the "too small for image" warning #1136

Closed
jviotti opened this issue Feb 25, 2017 · 13 comments
Closed

Comments

@jviotti
Copy link
Contributor

jviotti commented Feb 25, 2017

We should make sure the user understands why the drive is not large enough, which can be a bit confusing in the case of compressed images, where the compressed package is usually smaller than the drive.

@Shou
Copy link
Contributor

Shou commented Feb 27, 2017

Something like this? Although maybe "image size too big" "actual image size too big" or some such?

image

@lurch
Copy link
Contributor

lurch commented Feb 27, 2017

Might also be worth having an option to display the exact byte-sizes of both the uncompressed image and the drive in that scenario too, since with the units currently being always-rounded to GB, a "7.5GB" image may not actually fit on a "7.5GB" drive, if the image is even a few kilobytes larger than the drive.

@lurch
Copy link
Contributor

lurch commented Feb 27, 2017

Hmm, looking at @Shou 's screenshot I guess we need to be careful to try and keep the "warning label" small - maybe @konmouz has some ideas?

@Shou
Copy link
Contributor

Shou commented Feb 27, 2017

@lurch yeah, good call. Perhaps "Image Size Bigger By x units" and we just display in the appropriate human readable unit?

@jviotti
Copy link
Contributor Author

jviotti commented Feb 27, 2017

Let's bring @konmouz here.

@konmouz
Copy link

konmouz commented Feb 27, 2017

2 options:

  • we can have a 'insufficient space' label and on hover a tooltip with details (what @lurch suggested)
  • avoid the label and have just an the alert/ danger icon with the explanation, all in red - no tooltip

BTW, @Shou why the above element has two labels? System and boot? It would be better to stick to 1 label per drive. Also, boot drives should be greyed out and have a dark grey label.

@jviotti
Copy link
Contributor Author

jviotti commented Feb 27, 2017

I think I like the second option more, given that a tooltip might not be very discoverable unless the user however on the badge. In order to continue the brainstorm session: what about displaying the size that doesn't fit instead? E.g: You need 300 more MBs for the image.

@konmouz
Copy link

konmouz commented Feb 27, 2017

@jviotti this sounds even better. So using the label font size and the alert icon, we can display such a message. - Or, 300 MBs more are required for the selected image. -

@lurch
Copy link
Contributor

lurch commented Feb 27, 2017

BTW, @Shou why the above element has two labels? System and boot?

It's actually System and Source ;-) But yeah, it probably makes sense to only show one warning-label-per-drive, and I guess in this instance Source is 'more important' than System (a system drive may be writable, but a source drive (where the image is being read from) never will be).

With regards to the "too small" label message, what about "Drive is 300MB smaller than image" ?

@konmouz
Copy link

konmouz commented Feb 27, 2017

Sounds good to me, we should probably add the word 'selected' though, just to help user understand.

@alexandrosm
Copy link
Contributor

alexandrosm commented Feb 28, 2017 via email

@lurch
Copy link
Contributor

lurch commented Feb 28, 2017

I guess Source was chosen, as it's the logical-opposite of Destination, but you're right that it doesn't make much sense when seen in isolation. Difficult to thing of a more meaningful label though... what about something like "Image source" or "Image location" instead of "Source Drive"?

@jviotti
Copy link
Contributor Author

jviotti commented Feb 28, 2017

I created new issues to track some of the suggestions mentioned here:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants