Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve "Source Drive" drive selector badge wording #1144

Closed
jviotti opened this issue Feb 28, 2017 · 0 comments
Closed

Improve "Source Drive" drive selector badge wording #1144

jviotti opened this issue Feb 28, 2017 · 0 comments
Assignees
@Shou
Labels
component:gui platform:all
Milestone
Experience

Comments

@jviotti
Copy link
Contributor

jviotti commented Feb 28, 2017 •
edited by lurch
Loading

From #1136

"Source Drive" is hard to understand. Maybe something more obvious like "Drive contains image"?

EDIT: Orignally from #1136 (comment)
@jviotti jviotti added this to the Experience milestone Feb 28, 2017
@jviotti jviotti mentioned this issue Feb 28, 2017
Closed
Shou added a commit that referenced this issue Mar 21, 2017
@Shou
feat(GUI): new central error/warning messages function
ac92fcf 
* Centralise drive error/warning messages with a function
  `.getDriveFeedback` in `lib/shared/drive-constraints.js` -- tests
  included.
* Fix an error where several labels show at once.
* Clarify the source drive label to 'Drive Contains Image'
* Remove label icons and make text bold to match Zeplin's design

Closes: #1143
Closes: #1144
Changelog-Entry: New central function as the source of drive error
messages.
Shou added a commit that referenced this issue Mar 21, 2017
@Shou
feat(GUI): new central error/warning messages function
feb17b4 
* Centralise drive error/warning messages with a function
  `.getDriveFeedback` in `lib/shared/drive-constraints.js` -- tests
  included
* Fix an error where several labels show at once
* Clarify the source drive label to 'Drive Contains Image'
* Remove label icons and make text bold to match Zeplin's design

Closes: #1143
Closes: #1144
Changelog-Entry: New central function as the source of drive error
messages.
Shou added a commit that referenced this issue Mar 21, 2017
@Shou
feat(GUI): new central error/warning messages function
1637651 
* Centralise drive error/warning messages with a function
  `.getDriveFeedback` in `lib/shared/drive-constraints.js` -- tests
  included
* Fix an error where several labels show at once
* Clarify the source drive label to 'Drive Contains Image'
* Remove label icons and make text bold to match Zeplin's design

Closes: #1143
Closes: #1144
Changelog-Entry: New central function as the source of drive error
messages.
Shou added a commit that referenced this issue Mar 21, 2017
@Shou
feat(GUI): new central error/warning messages function
0facdb8 
* Centralise drive error/warning messages with a function
  `.getDriveFeedback` in `lib/shared/drive-constraints.js` -- tests
  included
* Fix an error where several labels show at once
* Clarify the source drive label to 'Drive Contains Image'
* Remove label icons and make text bold to match Zeplin's design

Closes: #1143
Closes: #1144
Changelog-Entry: New central function as the source of drive error
messages.
Shou added a commit that referenced this issue Mar 23, 2017
@Shou
feat(GUI): new central error/warning messages function
41a05c6 
* Centralise drive error/warning messages with a function
  `.getDriveImageCompatibilityStatus` in `lib/shared/drive-constraints.js` -- tests
  included
* Fix an error where several labels show at once
* Clarify the source drive label to 'Drive Contains Image'
* Remove label icons and make text bold to match Zeplin's design

Closes: #1143
Closes: #1144
Changelog-Entry: New central function as the source of drive error
messages.
Shou added a commit that referenced this issue Mar 23, 2017
@Shou
feat(GUI): new central error/warning messages function
ae99b8b 
* Centralise drive error/warning messages with a function
  `.getDriveImageCompatibilityStatus` in `lib/shared/drive-constraints.js` -- tests
  included
* Fix an error where several labels show at once
* Clarify the source drive label to 'Drive Contains Image'
* Remove label icons and make text bold to match Zeplin's design

Closes: #1143
Closes: #1144
Changelog-Entry: New central function as the source of drive error
messages.
Shou added a commit that referenced this issue Mar 24, 2017
@Shou
feat(GUI): new central error/warning messages function
ded9322 
* Centralise drive error/warning messages with a function
  `.getDriveImageCompatibilityStatus` in `lib/shared/drive-constraints.js` -- tests
  included
* Fix an error where several labels show at once
* Clarify the source drive label to 'Drive Contains Image'
* Remove label icons and make text bold to match Zeplin's design

Closes: #1143
Closes: #1144
Changelog-Entry: New central function as the source of drive error
messages.
Shou added a commit that referenced this issue Mar 24, 2017
@Shou
feat(GUI): new central error/warning messages function
bed7541 
* Centralise drive error/warning messages with a function
  `.getDriveImageCompatibilityStatus` in `lib/shared/drive-constraints.js` -- tests
  included
* Fix an error where several labels show at once
* Clarify the source drive label to 'Drive Contains Image'
* Remove label icons and make text bold to match Zeplin's design

Closes: #1143
Closes: #1144
Changelog-Entry: New central function as the source of drive error
messages.
Shou added a commit that referenced this issue Mar 24, 2017
@Shou
feat(GUI): new central error/warning messages function
238381f 
* Centralise drive error/warning messages with a function
  `.getDriveImageCompatibilityStatus` in `lib/shared/drive-constraints.js` -- tests
  included
* Fix an error where several labels show at once
* Clarify the source drive label to 'Drive Contains Image'
* Remove label icons and make text bold to match Zeplin's design

Closes: #1143
Closes: #1144
Changelog-Entry: New central function as the source of drive error
messages.
Shou added a commit that referenced this issue Mar 24, 2017
@Shou
feat(GUI): new central error/warning messages function
dce10be 
* Centralise drive error/warning messages with a function
  `.getDriveImageCompatibilityStatus` in `lib/shared/drive-constraints.js` -- tests
  included
* Fix an error where several labels show at once
* Clarify the source drive label to 'Drive Contains Image'
* Remove label icons and make text bold to match Zeplin's design

Closes: #1143
Closes: #1144
Changelog-Entry: New central function as the source of drive error
messages.
Shou added a commit that referenced this issue Mar 24, 2017
@Shou
feat(GUI): new central error/warning messages function
b6dbc90 
* Centralise drive error/warning messages with a function
  `.getDriveImageCompatibilityStatus` in `lib/shared/drive-constraints.js` -- tests
  included
* Fix an error where several labels show at once
* Clarify the source drive label to 'Drive Contains Image'
* Remove label icons and make text bold to match Zeplin's design

Closes: #1143
Closes: #1144
Changelog-Entry: New central function as the source of drive error
messages.
@Shou Shou mentioned this issue Mar 27, 2017
Merged
Shou added a commit that referenced this issue Mar 28, 2017
@Shou
refactor(GUI): central error/warning messages function
cd07b74 
* Centralise drive error/warning messages with a function
  `.getDriveImageCompatibilityStatuses` in `lib/shared/drive-constraints.js`
  -- tests included
* Fix an error where several labels show at once
* Clarify the source drive label to 'Drive Contains Image'
* Remove label icons and make text bold to match Zeplin's design

Closes: #1143
Closes: #1144
Changelog-Entry: New central function as the source of drive error
messages.
Shou added a commit that referenced this issue Apr 11, 2017
@Shou
refactor(GUI): central error/warning messages function
f938a56 
* Centralise drive error/warning messages with a function
  `.getDriveImageCompatibilityStatuses` in `lib/shared/drive-constraints.js`
  -- tests included
* Fix an error where several labels show at once
* Clarify the source drive label to 'Drive Contains Image'
* Remove label icons and make text bold to match Zeplin's design

Closes: #1143
Closes: #1144
Changelog-Entry: New central function as the source of drive error
messages.
Shou added a commit that referenced this issue Apr 13, 2017
@Shou
refactor(GUI): central error/warning messages function
06b56a0 
* Centralise drive error/warning messages with a function
  `.getDriveImageCompatibilityStatuses` in `lib/shared/drive-constraints.js`
  -- tests included
* Fix an error where several labels show at once
* Clarify the source drive label to 'Drive Contains Image'
* Remove label icons and make text bold to match Zeplin's design

Closes: #1143
Closes: #1144
Changelog-Entry: New central function as the source of drive error
messages.
Shou added a commit that referenced this issue Apr 18, 2017
@Shou
refactor(GUI): central error/warning messages function
384d0b3 
* Centralise drive error/warning messages with a function
  `.getDriveImageCompatibilityStatuses` in `lib/shared/drive-constraints.js`
  -- tests included
* Fix an error where several labels show at once
* Clarify the source drive label to 'Drive Contains Image'
* Remove label icons and make text bold to match Zeplin's design

Closes: #1143
Closes: #1144
Changelog-Entry: New central function as the source of drive error
messages.
Shou added a commit that referenced this issue Apr 26, 2017
@Shou
refactor(GUI): central error/warning messages function
380eec2 
* Centralise drive error/warning messages with a function
  `.getDriveImageCompatibilityStatuses` in `lib/shared/drive-constraints.js`
  -- tests included
* Fix an error where several labels show at once
* Clarify the source drive label to 'Drive Contains Image'
* Remove label icons and make text bold to match Zeplin's design

Closes: #1143
Closes: #1144
Changelog-Entry: New central function as the source of drive error
messages.
Shou added a commit that referenced this issue May 8, 2017
@Shou
refactor(GUI): central error/warning messages function
4248173 
* Centralise drive error/warning messages with a function
  `.getDriveImageCompatibilityStatuses` in `lib/shared/drive-constraints.js`
  -- tests included
* Fix an error where several labels show at once
* Clarify the source drive label to 'Drive Contains Image'
* Remove label icons and make text bold to match Zeplin's design

Closes: #1143
Closes: #1144
Changelog-Entry: New central function as the source of drive error
messages.
Shou added a commit that referenced this issue May 9, 2017
@Shou
refactor(GUI): central error/warning messages function
c84a218 
* Centralise drive error/warning messages with a function
  `.getDriveImageCompatibilityStatuses` in `lib/shared/drive-constraints.js`
  -- tests included
* Fix an error where several labels show at once
* Clarify the source drive label to 'Drive Contains Image'
* Remove label icons and make text bold to match Zeplin's design

Closes: #1143
Closes: #1144
Changelog-Entry: New central function as the source of drive error
messages.
jviotti pushed a commit that referenced this issue May 10, 2017
@Shou
refactor(GUI): central error/warning messages function (#1193)
b6aa5ad 
* Centralise drive error/warning messages with a function
  `.getDriveImageCompatibilityStatuses` in `lib/shared/drive-constraints.js`
  -- tests included
* Fix an error where several labels show at once
* Clarify the source drive label to 'Drive Contains Image'
* Remove label icons and make text bold to match Zeplin's design

Closes: #1143
Closes: #1144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shou Shou

Labels
component:gui platform:all
Projects
None yet
Milestone
Experience
Development

No branches or pull requests
2 participants
@Shou @jviotti