Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove experimental file picker #2993

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Remove experimental file picker #2993

merged 1 commit into from
Dec 4, 2019

Conversation

zvin
Copy link
Contributor

@zvin zvin commented Dec 4, 2019

Change-type: patch

sradevski
sradevski approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@sradevski sradevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the experimental file picker was supposed to do, but I say thumbs up for any removal 😄

@zvin
Copy link
Contributor Author

zvin commented Dec 4, 2019

@sradevski it was a react file picker that replaced the operating system file picker when enabled.
It was moved here https://github.com/balena-io-modules/balena-electronjs/tree/master/src/ui/file-selector

@zvin zvin merged commit 1eb39c2 into remove-angular Dec 4, 2019
@zvin zvin deleted the remove-file-picker branch December 16, 2019 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sradevski sradevski sradevski approved these changes

@jviotti jviotti Awaiting requested review from jviotti

@thundron thundron Awaiting requested review from thundron

@LucianBuzzo LucianBuzzo Awaiting requested review from LucianBuzzo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvin @sradevski