Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple connection pool from HTTP client #13355

Merged
merged 18 commits into from
Feb 5, 2019

Conversation

arukshani
Copy link
Member

Purpose

Is to decouple the connection pool from HTTP client.

Approach

By default HTTP clients will share a global pool but they also has a way to configure their own pool

Automation tests

  • Unit tests Added

Security checks

@arukshani arukshani added Team/StandardLibs All Ballerina standard libraries Component/HTTP labels Jan 28, 2019
@codecov-io
Copy link

codecov-io commented Feb 1, 2019

Codecov Report

Merging #13355 into master will increase coverage by <.01%.
The diff coverage is 81.48%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #13355      +/-   ##
============================================
+ Coverage     63.98%   63.99%   +<.01%     
  Complexity      659      659              
============================================
  Files          2147     2148       +1     
  Lines         94210    94305      +95     
  Branches      12406    12414       +8     
============================================
+ Hits          60281    60350      +69     
- Misses        29035    29059      +24     
- Partials       4894     4896       +2
Impacted Files Coverage Δ Complexity Δ
...nalang/net/http/clientendpoint/InitGlobalPool.java 100% <100%> (ø) 0 <0> (?)
...main/java/org/ballerinalang/net/http/HttpUtil.java 72.32% <74.54%> (-1.03%) 0 <0> (ø)
...et/http/clientendpoint/CreateSimpleHttpClient.java 88.63% <94.44%> (+2.92%) 0 <0> (ø) ⬇️
...allerinalang/net/jms/LoggingExceptionListener.java 50% <0%> (-50%) 0% <0%> (ø)
...rinalang/runtime/threadpool/ThreadPoolFactory.java 61.9% <0%> (-4.77%) 0% <0%> (ø)
...a/org/ballerinalang/bre/bvm/WorkerDataChannel.java 83.95% <0%> (-4.33%) 0% <0%> (ø)
...mantics/analyzer/StreamsQuerySemanticAnalyzer.java 87.47% <0%> (+0.13%) 0% <0%> (ø) ⬇️
...inalang/compiler/desugar/StreamingCodeDesugar.java 96.73% <0%> (+0.35%) 0% <0%> (ø) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c0bc10...816bbd1. Read the comment docs.

@arukshani arukshani merged commit 50aef30 into ballerina-platform:master Feb 5, 2019
@arukshani arukshani added this to the 0.991.0 milestone Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/StandardLibs All Ballerina standard libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants