Merge pull request #1434 from vil02/4930_make_some_java_classes_prope…

…r_utilities Make some Java classes proper utilities
ballerina-platform · Oct 17, 2023 · a27b6fe · a27b6fe
2 parents 66f581b + 006c6d9
commit a27b6fe
Show file tree

Hide file tree

Showing 7 changed files with 19 additions and 6 deletions.
diff --git a/ballerina/Ballerina.toml b/ballerina/Ballerina.toml
@@ -35,7 +35,7 @@ scope = "testOnly"
 groupId = "io.ballerina.stdlib"
 artifactId = "http-native"
 version = "2.10.3"
-path = "./lib/http-native-2.10.3-20231011-163800-7c8069a.jar"
+path = "./lib/http-native-2.10.3.jar"
 
 [[platform.java17.dependency]]
 groupId = "io.netty"

diff --git a/changelog.md b/changelog.md
@@ -8,6 +8,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 - [Fixed error response from backend not getting properly propegated to the client](https://github.com/ballerina-platform/ballerina-standard-library/issues/4833)
 
+### Changed
+- [Make some of the Java classes proper utility classes](https://github.com/ballerina-platform/ballerina-standard-library/issues/4930)
+
 ## [1.9.1] - 2023-09-11
 ### Fixed
 - [Address CVE-2023-33201 bouncy castle vulnerability](https://github.com/ballerina-platform/ballerina-standard-library/issues/4776)

diff --git a/...ler-plugin/src/main/java/io/ballerina/stdlib/grpc/plugin/GrpcCompilerPluginConstants.java b/...ler-plugin/src/main/java/io/ballerina/stdlib/grpc/plugin/GrpcCompilerPluginConstants.java
@@ -23,7 +23,9 @@
 /**
  * gRPC compiler plugin constants.
  */
-public class GrpcCompilerPluginConstants {
+public final class GrpcCompilerPluginConstants {
+
+    private GrpcCompilerPluginConstants() {}
 
     // Compiler plugin constants
     public static final String GRPC_SERVICE_DESCRIPTOR_ANNOTATION_NAME = "ServiceDescriptor";

diff --git a/native/src/main/java/io/ballerina/stdlib/grpc/StandardDescriptorBuilder.java b/native/src/main/java/io/ballerina/stdlib/grpc/StandardDescriptorBuilder.java
@@ -42,7 +42,9 @@
 /**
  * Provides protobuf descriptor for well known dependency.
  */
-public class StandardDescriptorBuilder {
+public final class StandardDescriptorBuilder {
+
+    private StandardDescriptorBuilder() {}
 
     private static final Map<String, Descriptors.FileDescriptor> standardLibDescriptorMapForPackageKey;
     private static final Map<String, Descriptors.FileDescriptor> standardLibDescriptorMapForMessageName;

diff --git a/native/src/test/java/io/ballerina/stdlib/grpc/util/TestUtils.java b/native/src/test/java/io/ballerina/stdlib/grpc/util/TestUtils.java
@@ -32,7 +32,9 @@
 /**
  * A util class to be used for native tests.
  */
-public class TestUtils {
+public final class TestUtils {
+
+    private TestUtils() {}
 
     public static BObject getBObject(Map<String, Field> fieldMap) {
         BObject bObject = Mockito.mock(BObject.class);

diff --git a/test-utils/src/main/java/io/ballerina/stdlib/grpc/testutils/EnvironmentTestUtils.java b/test-utils/src/main/java/io/ballerina/stdlib/grpc/testutils/EnvironmentTestUtils.java
@@ -24,7 +24,9 @@
  * This class holds test utility APIs related to check the running OS.
  *
  */
-public class EnvironmentTestUtils {
+public final class EnvironmentTestUtils {
+
+    private EnvironmentTestUtils() {}
 
     public static boolean isWindowsEnvironment() {
         return System.getProperty("os.name").toLowerCase(Locale.ENGLISH).contains("win");

diff --git a/test-utils/src/main/java/io/ballerina/stdlib/grpc/testutils/NativeTestUtils.java b/test-utils/src/main/java/io/ballerina/stdlib/grpc/testutils/NativeTestUtils.java
@@ -47,7 +47,9 @@
  * Utility methods to test the native functions of client endpoint.
  *
  */
-public class NativeTestUtils {
+public final class NativeTestUtils {
+
+    private NativeTestUtils() {}
 
     public static Object externInvokeInitStubNullRootDescriptor(BObject clientEndpoint) {
         return FunctionUtils.externInitStub(clientEndpoint, null, null, null);