Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict Agent's input schema to use types supported by JSON Schema #46

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Restrict Agent's input schema to use types supported by JSON Schema #46

merged 3 commits into from
Feb 15, 2024

Conversation

nadheesh
Copy link
Contributor

@SasinduDilshara
Copy link
Contributor

According to the issue it says, agent should only support string, number, integer, object, array, and boolean.
So, according to that Is it ok to supports float as a number in here.

@SasinduDilshara
Copy link
Contributor

And also if we don't support float can't we remove it from the enum defined as InputType.

@nadheesh
Copy link
Contributor Author

That is the expected behavior, we want to always refer float as numbers when we convert OpenAPI spec to JSON schema. Also, float is defined as a type because it is still supported with OpenAPI specs

@nadheesh nadheesh merged commit e288bc1 into ballerina-platform:main Feb 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SasinduDilshara SasinduDilshara SasinduDilshara approved these changes

@malithjayasinghe malithjayasinghe Awaiting requested review from malithjayasinghe malithjayasinghe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nadheesh @SasinduDilshara