Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to new compiler extension #191

Merged
merged 2 commits into from
Jun 4, 2021

Conversation

xlight05
Copy link
Contributor

@xlight05 xlight05 commented May 26, 2021

Purpose

  1. Extension now generates resource functions per each az function instead of storing handler functions in a map.
  2. Removes old Compiler Plugin implementation and migrates to new compiler extension model
  3. Cleans and refactor gradle scripts

Resolves #200
Resolves #201

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email documentation@wso2.com to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to certification@wso2.com and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

@xlight05 xlight05 requested a review from anuruddhal May 26, 2021 07:53
@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

Merging #191 (74c7954) into new-extension (88bf5a7) will decrease coverage by 0.98%.
The diff coverage is 91.30%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             new-extension     #191      +/-   ##
===================================================
- Coverage            79.56%   78.58%   -0.99%     
- Complexity             217      232      +15     
===================================================
  Files                   32       37       +5     
  Lines                 1204     1396     +192     
  Branches               125      138      +13     
===================================================
+ Hits                   958     1097     +139     
- Misses                 156      202      +46     
- Partials                90       97       +7     
Impacted Files Coverage Δ
.../java/org/ballerinax/azurefunctions/Constants.java 0.00% <ø> (ø)
...lerinax/azurefunctions/AzureCodeGeneratedTask.java 69.56% <69.56%> (ø)
...rg/ballerinax/azurefunctions/AzureCodegenTask.java 89.18% <89.18%> (ø)
...ain/java/org/ballerinax/azurefunctions/STUtil.java 76.99% <93.15%> (-4.29%) ⬇️
.../ballerinax/azurefunctions/AzureCodeGenerator.java 100.00% <100.00%> (ø)
...ballerinax/azurefunctions/AzureCompilerPlugin.java 100.00% <100.00%> (ø)
...lerinax/azurefunctions/AzureFunctionExtractor.java 100.00% <100.00%> (ø)
...ballerinax/azurefunctions/AzureFunctionHolder.java 100.00% <100.00%> (ø)
...allerinax/azurefunctions/AzureFunctionVisitor.java 73.68% <100.00%> (+1.46%) ⬆️
...lerinax/azurefunctions/AzureLifecycleListener.java 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eb0b58...74c7954. Read the comment docs.

@anuruddhal anuruddhal merged commit 675a3e3 into ballerina-platform:new-extension Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants